From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 2/9] lib: split tst_fill_file() to create new tst_fill_fd()
Date: Thu, 21 Feb 2019 13:04:42 +0100 [thread overview]
Message-ID: <20190221120442.GB17813@rei.lan> (raw)
In-Reply-To: <20190221113840.l2ffu4d22u72uakm@holly.lan>
Hi!
> > -int tst_fill_file(const char *path, char pattern, size_t bs, size_t bcount)
> > +int tst_fill_fd(int fd, char pattern, size_t bs, size_t bcount)
> > {
> > - int fd;
> > - size_t counter;
> > + size_t i;
>
> Nitpicking perhaps but gratuitous variable renames don't make patches
> containing other changes easier to read. Nor, to be honest, does
> "counter" seem any more descriptive then i (since i is more idiomatic
> and therefore quicker to read).
It seems you misread the patch as we are replacing the counter with i
here and I asked for that since i is the idiomatic way of naming loop
variables, so all the blame for this change goes to me :-).
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-02-21 12:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 9:00 [LTP] [PATCH v4 0/9] syscalls: add sync device test-cases Sumit Garg
2019-02-21 9:00 ` [LTP] [PATCH v4 1/9] lib/tst_device: add new api tst_dev_bytes_written() Sumit Garg
2019-02-25 15:21 ` Cyril Hrubis
2019-02-26 6:01 ` Sumit Garg
2019-02-21 9:00 ` [LTP] [PATCH v4 2/9] lib: split tst_fill_file() to create new tst_fill_fd() Sumit Garg
2019-02-21 11:38 ` Daniel Thompson
2019-02-21 12:04 ` Cyril Hrubis [this message]
2019-02-21 13:36 ` Daniel Thompson
2019-02-25 15:22 ` Cyril Hrubis
2019-02-26 6:04 ` Sumit Garg
2019-02-21 9:00 ` [LTP] [PATCH v4 3/9] lib/tst_test: define TEST_VOID() macro Sumit Garg
2019-02-21 9:00 ` [LTP] [PATCH v4 4/9] syscalls: add syncfs() sync device test-case Sumit Garg
2019-02-21 9:00 ` [LTP] [PATCH v4 5/9] syscalls/sync: add " Sumit Garg
2019-02-21 9:00 ` [LTP] [PATCH v4 6/9] syscalls/fsync: " Sumit Garg
2019-02-21 9:00 ` [LTP] [PATCH v4 7/9] syscalls/fdatasync: " Sumit Garg
2019-02-21 9:00 ` [LTP] [PATCH v4 8/9] syscalls/sync_file_range: Use C library wrapper if present Sumit Garg
2019-02-21 9:00 ` [LTP] [PATCH v4 9/9] syscalls/sync_file_range: add sync device test-case Sumit Garg
2019-02-25 15:26 ` Cyril Hrubis
2019-02-26 9:02 ` Sumit Garg
2019-02-26 10:57 ` Cyril Hrubis
2019-02-26 11:48 ` Daniel Thompson
2019-02-26 13:34 ` Sumit Garg
2019-02-25 15:19 ` [LTP] [PATCH v4 0/9] syscalls: add sync device test-cases Cyril Hrubis
2019-02-26 5:59 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221120442.GB17813@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox