From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/ustat: Move the syscall to lapi
Date: Thu, 21 Feb 2019 15:30:22 +0100 [thread overview]
Message-ID: <20190221143021.GC17813@rei.lan> (raw)
In-Reply-To: <87r2c12udf.fsf@rpws.prws.suse.cz>
Hi!
> > diff --git a/include/lapi/ustat.h b/include/lapi/ustat.h
> > index 12c073582..6365b2e92 100644
> > --- a/include/lapi/ustat.h
> > +++ b/include/lapi/ustat.h
> > @@ -10,12 +10,19 @@
> > #ifdef HAVE_SYS_USTAT_H
> > # include <sys/ustat.h>
>
> Just a thought, but this is potentially a problem if lib C implementes
> ustat in user land, but the system call still exists. Which I think is
> more likely with an obsolete system call.
Good point. So it all depends on what we want to focus on, if we are
after kernel, we should call the syscall directly, if we look at system
functionality we should go after the libc one by default.
I guess that ideally we should test both, not sure how to achiveve that
reasonably easily...
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-02-21 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 11:22 [LTP] [PATCH] syscalls/ustat: Move the syscall to lapi Cyril Hrubis
2019-02-21 12:34 ` Richard Palethorpe
2019-02-21 14:30 ` Cyril Hrubis [this message]
2019-02-21 14:50 ` pvorel
2019-02-22 7:39 ` Richard Palethorpe
2019-02-22 15:00 ` Cyril Hrubis
2019-02-22 19:43 ` Steve Muckle
2019-02-25 12:18 ` Cyril Hrubis
2019-02-22 19:29 ` Steve Muckle
2019-06-03 13:10 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221143021.GC17813@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox