public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] cgroup_regression_test.sh: Fix TWARN usage
Date: Tue, 26 Feb 2019 19:42:28 +0100	[thread overview]
Message-ID: <20190226184228.GA1113@dell5510> (raw)
In-Reply-To: <20190215145239.51806-2-cristian.marussi@arm.com>

Hi Cristian,

> Using TWARN to report that a specific sub-testcase is skipped
> caused the whole cgroup_regression_test.sh to be reported as
> FAILING. Using TCONF instead.

Fixes: 78bfa7e78 ("cgroup: Simplify check_kernel_bug usage")
My commit, sorry :(.

> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
>  testcases/kernel/controllers/cgroup/cgroup_regression_test.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> index 686860923..e197f5d3f 100755
> --- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> +++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> @@ -408,7 +408,7 @@ test_7_2()

>  	grep -q -w "cpu" /proc/cgroups
>  	if [ $? -ne 0 -o ! -e /proc/sched_debug ]; then
> -		tst_res TWARN "skip rest of testing due possible oops triggered by reading /proc/sched_debug"
> +		tst_res TCONF "skip rest of testing due possible oops triggered by reading /proc/sched_debug"
Right, TWARN is not good (IMHO TWARN is not popular in LTP testsuites due marking test failing),
but if you don't mind I'd merge it with TBROK (more appropriate in this case).

Other option would be to use TINFO and don't skip test (we're trying to find
kernel crashes, don't we), that's probably a bit crazy.

Kind regards,
Petr

  reply	other threads:[~2019-02-26 18:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15 14:52 [LTP] [RFC][PATCH 0/1] cgroup_regression_test.sh fix Cristian Marussi
2019-02-15 14:52 ` [LTP] [PATCH 1/1] cgroup_regression_test.sh: Fix TWARN usage Cristian Marussi
2019-02-26 18:42   ` Petr Vorel [this message]
2019-02-26 18:51     ` Cristian Marussi
2019-02-27 11:10       ` Petr Vorel
2019-02-27 11:45       ` Petr Vorel
2019-02-27 10:37 ` [LTP] [RFC][PATCH 0/1] cgroup_regression_test.sh fix Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226184228.GA1113@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox