public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2 v4] syscalls: Add set_mempolicy numa tests.
Date: Wed, 6 Mar 2019 16:30:54 +0100	[thread overview]
Message-ID: <20190306153054.GC12479@rei> (raw)
In-Reply-To: <2092842506.4709417.1551685162547.JavaMail.zimbra@redhat.com>

Hi!
> > We also check for free memory on each numa memory mode and skip nodes
> > that don't have sufficient amount of memory for a particular test. The
> > tests checks usuall for twice as much memory per each node in order to
> > allow for allocations to be "misplaced".
> 
> I wonder if we should add some constant to it. I have foggy idea, that
> kernel keeps some reserves.

Hmm, no idea about this, I guess that adding a few megabytes for a good
luck in the library wouldn't do any harm.

> > The tests for file based shared interleaved mappings are no longer
> > mapping a single small file but rather than that we accumulate statistic
> > for larger amount of files over longer period of time and we also allow
> > for small offset (currently 10%). We should probably also increase the
> > number of samples we take as currently it's about 5MB in total on x86
> > although I haven't managed to make this test fail so far. This also
> > fixes the test on Btrfs where the synthetic test that expects the pages
> > to be distributed exactly equally fails.
> 
> API looks good to me, ACK. Maybe you could split it into 2 commits, one for
> new library API, and one for new tests.

Sure, will do.

Ok to commit the library and set_mempolicy() tests with fixed nits you
pointed out below or should I spin v5?

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2019-03-06 15:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28 15:34 [LTP] [PATCH 0/2 v4] Add mbind and set_mempolicy tests Cyril Hrubis
2019-02-28 15:34 ` [LTP] [PATCH 1/2 v4] syscalls: Add set_mempolicy numa tests Cyril Hrubis
2019-03-04  7:39   ` Jan Stancek
2019-03-06 15:30     ` Cyril Hrubis [this message]
2019-03-06 15:38       ` Jan Stancek
2019-02-28 15:34 ` [LTP] [PATCH 2/2] syscalls/mbind0{2,3,4}: Add basic mbind tests Cyril Hrubis
2019-06-03 14:04   ` [LTP] [PATCH 2/2] syscalls/mbind0{2, 3, 4}: " Petr Vorel
2019-06-03 14:12   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190306153054.GC12479@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox