From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] setpriority01: Skip only PRIO_USER when unable to add test user
Date: Thu, 7 Mar 2019 11:59:33 +0100 [thread overview]
Message-ID: <20190307105933.GA1040@rei.lan> (raw)
In-Reply-To: <20190306215859.66044-1-saravanak@google.com>
Hi!
> - ltpuser = SAFE_GETPWNAM(username);
> - uid = ltpuser->pw_uid;
> + if (!tst_run_cmd(cmd_useradd, NULL, NULL, 1)) {
> + user_added = 1;
> + ltpuser = SAFE_GETPWNAM(username);
> + uid = ltpuser->pw_uid;
> + }
The only thing that I don't like here is that we do not check the cause
of failure here. What exactly happens on android, is useradd missing
there completely? If so we should proceed with TCONF only if
tst_run_cmd() returned 255 and TBROK the test on other non-zero return
values.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-03-07 10:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 21:58 [LTP] [PATCH] setpriority01: Skip only PRIO_USER when unable to add test user Saravana Kannan
2019-03-07 10:59 ` Cyril Hrubis [this message]
2019-03-07 15:44 ` Saravana Kannan
2019-03-07 22:36 ` Saravana Kannan
2019-03-11 16:04 ` Cyril Hrubis
2019-03-11 18:23 ` Saravana Kannan
2019-03-13 18:54 ` Saravana Kannan
2019-03-19 10:06 ` Cyril Hrubis
2019-03-11 16:00 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307105933.GA1040@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox