public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Fix build with libnuma-dev on some distributions
Date: Fri, 8 Mar 2019 11:43:38 +0100	[thread overview]
Message-ID: <20190308104338.GA16584@dell5510> (raw)
In-Reply-To: <361211632.5905441.1551973237001.JavaMail.zimbra@redhat.com>

Hi,

> ----- Original Message -----
> > On some distributions when libnuma-dev is installed the tst_numa.o,
> > which was added to libltp.a pulls in symbols from numa library to random
> > unrealted tests which breaks the build.

> > This commit hence moves the tst_numa to a separate libltpnuma.a library
> > that is used for linking only for tests that actually use it and link
> > with -lnuma.

> > Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> > CC: Jan Stancek <jstancek@redhat.com>
> > ---

> > This should fix the build failures, beware not build tested yet.
The problem persists [1] [2]:
/usr/src/ltp/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c:105: undefined reference to `numa_allocate_nodemask'
/usr/src/ltp/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c:110: undefined reference to `numa_bitmask_setbit'
/usr/src/ltp/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c:112: undefined reference to `set_mempolicy'

> I'm fine with approach. I'd suggest different directory name, but
> it's hard to come up with something nice. Maybe:
> libnumafn, libnumautils (maybe taken), libtstnuma

> Might be less confusing if it doesn't share same name as existing
> library.
Agree.

+ other LTP libraries are hidden in some subdirectories (which might be
confusing), but I like there is not lib/ and lib<foo>/ in root directory.

Kind regards,
Petr

[1] https://api.travis-ci.org/v3/job/503536791/log.txt
[2] https://travis-ci.org/pevik/ltp/jobs/503536791

  reply	other threads:[~2019-03-08 10:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07 14:34 [LTP] [PATCH] Fix build with libnuma-dev on some distributions Cyril Hrubis
2019-03-07 15:40 ` Jan Stancek
2019-03-08 10:43   ` Petr Vorel [this message]
2019-03-08 11:34     ` Cyril Hrubis
2019-03-08 11:47       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190308104338.GA16584@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox