From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2 v2] libs: Hook up libs into the build system
Date: Fri, 8 Mar 2019 14:33:47 +0100 [thread overview]
Message-ID: <20190308133347.GB20072@rei> (raw)
In-Reply-To: <20190308132634.GA23955@dell5510>
Hi!
> > I tested v2 as far back as RHEL6.2, ACK.
> Jan, have you tested out of tree build?
>
> Still failing [1], mostly for out-of-tree builds [2]:
> make: Entering directory '/usr/src/ltp-build'
> make -C "lib" \
> -f "/usr/src/ltp/lib/Makefile" all
> make -C "libs" \
> -f "/usr/src/ltp/libs/Makefile" all
> make[1]: Entering directory '/usr/src/ltp-build/lib'
> mkdir -m 00755 -p "newlib_tests"
> make[1]: Entering directory '/usr/src/ltp-build'
> make[1]: *** libs: No such file or directory. Stop.
> make[1]: Leaving directory '/usr/src/ltp-build'
> /usr/src/ltp/Makefile:114: recipe for target 'libs-all' failed
> make: *** [libs-all] Error 2
> make: *** Waiting for unfinished jobs....
Sigh, the out-of-tree build is always making things unnecessary
difficuilt. I have no idea why the directory is not created in the build
tree.
> And i386 for Debian has still the same error [3]:
> /usr/src/ltp/libs/libltpnuma/tst_numa.c:200: undefined /tmp/ccO9srN7.o: In function `verify_set_mempolicy':
> /usr/src/ltp/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c:105: undefined reference to `numa_allocate_nodemask'
> /usr/src/ltp/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c:110: undefined reference to `numa_bitmask_setbit'
> /usr/src/ltp/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c:112: undefined reference to `set_mempolicy'
Not at all, this is very different problem :-). Now it fails to build in
these tests that actually use the library. So original problem was fixed
and this is quite possibly wrong config guards used in the tst_numa.c.
I do use ifdef HAVE_NUMA_H in the library in the library and tests it
should be probably replaced by HAVE_NUMA_V2.
Still I would say that the original patches should be pushed and that we
should deal with the rest of the problems in separate ones.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-03-08 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 12:42 [LTP] [PATCH 1/2 v2] Fix build with libnuma-dev on some distributions Cyril Hrubis
2019-03-08 12:42 ` [LTP] [PATCH 2/2 v2] libs: Hook up libs into the build system Cyril Hrubis
2019-03-08 13:05 ` Jan Stancek
2019-03-08 13:26 ` Petr Vorel
2019-03-08 13:28 ` Jan Stancek
2019-03-08 13:33 ` Cyril Hrubis [this message]
2019-03-08 14:03 ` Cyril Hrubis
2019-03-08 15:09 ` Petr Vorel
2019-03-08 15:10 ` Cyril Hrubis
2019-03-08 13:27 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308133347.GB20072@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox