public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] verify_caps_exec: Respect TMP environment variable
Date: Wed, 13 Mar 2019 12:07:11 +0100	[thread overview]
Message-ID: <20190313110711.GA2606@dell5510> (raw)
In-Reply-To: <93480014.31836255.1531299278505.JavaMail.zimbra@redhat.com>

Hi Alistair, Jan,

> ----- Original Message -----
> > The filecapstest.sh wrapper script already allows the /tmp directory to
> > be overridden with the TMP environment variable, however doing so has
> > no effect on verify_caps_exec because it creates its own version of this
> > fifo at a hardcoded location under /tmp.

> > To ensure the fifo is correctly removed by the wrapper script, alter
> > verify_caps_exec to respect the TMP environment variable and create a
> > fifo at the same location.

> Hi,

> this doesn't seem to be enough, print_caps.c is also hardcoding /tmp.
> Other than rewriting the test, I'm thinking simplest way to fix this is:

> 1. export FIFOFILE in wrapper script and then use that env. variable
> in all *.c tests.

> 2. change wrapper script to use $TMPDIR if available
> (that is the value exported by runltp)

> What do you think?
I guess this issue has been solved by 
cf8bd0327 ("filecaps: Respect TMPDIR environment variable"), thus closing it in
patchwork [1]

> Regards,
> Jan

Kind regards,
Petr

[1] https://patchwork.ozlabs.org/patch/934131/

      parent reply	other threads:[~2019-03-13 11:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22 23:23 [LTP] [PATCH] verify_caps_exec: Respect TMP environment variable Alistair Strachan
2018-07-11  8:54 ` Jan Stancek
2018-07-11 21:03   ` [LTP] [PATCH] filecaps: Respect TMPDIR " Alistair Strachan
2018-07-17  8:13     ` Jan Stancek
2019-03-13 11:07   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190313110711.GA2606@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox