From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/3] syscalls/tgkill01: add new test
Date: Fri, 15 Mar 2019 11:18:11 +0100 [thread overview]
Message-ID: <20190315101810.GB5383@rei> (raw)
In-Reply-To: <CAFA6WYPNLiE1gFDko1uV8wnnyBVdX4CUyo0od7AkkoYgYQ6Dhg@mail.gmail.com>
Hi!
> Wouldn't this loop be more appropriate in
> "tst_safe_checkpoint_wait()"? As at later stage we may have tests that
> depends on checkpoints being interrupted by signals and could directly
> use "tst_checkpoint_wait()".
The tst_checkpoint_wait() has a single use in the source tree and that
is testcases/lib/tst_checkpoint.c which is binary wrapper around
checkpoints so that we can use them in shell scripts as well, which is
pretty cool btw. And I think that we should retry on EINTR there as
well.
Also there does not seem to be test relying on checkpoints being
interrupted by signals and I would like to avoid this pattern ideally as
asynchronous events such as signals interrupting functions is something
rather counter intuitive.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-03-15 10:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 6:12 [LTP] [PATCH v2 0/3] syscalls: add tgkill test-cases Sumit Garg
2019-03-13 6:12 ` [LTP] [PATCH v2 1/3] syscalls/tgkill01: add new test Sumit Garg
2019-03-14 12:22 ` Cyril Hrubis
2019-03-14 13:25 ` Sumit Garg
2019-03-14 13:58 ` Cyril Hrubis
2019-03-15 7:45 ` Li Wang
2019-03-15 9:22 ` Sumit Garg
2019-03-15 10:08 ` Cyril Hrubis
2019-03-15 10:23 ` Li Wang
2019-03-15 11:33 ` Cyril Hrubis
2019-03-18 6:39 ` Li Wang
2019-03-15 9:15 ` Sumit Garg
2019-03-15 10:18 ` Cyril Hrubis [this message]
2019-03-15 14:01 ` Sumit Garg
2019-03-18 12:59 ` Cyril Hrubis
2019-03-13 6:12 ` [LTP] [PATCH v2 2/3] syscalls/tgkill02: " Sumit Garg
2019-03-13 6:12 ` [LTP] [PATCH v2 3/3] syscalls/tgkill03: " Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315101810.GB5383@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox