From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH RFC] lib: invoke do_cleanup if failed to kill test processes
Date: Mon, 18 Mar 2019 13:28:52 +0100 [thread overview]
Message-ID: <20190318122851.GC10187@rei> (raw)
In-Reply-To: <20190315061733.24938-1-liwang@redhat.com>
Hi!
> LTP liabary should invoke do_cleanup function promptly when killing
> test process doesn't work, especially useful to testcase do mount or
> format devices in their setup phase. Otherwise, that abnormal broken
> will effect the testcase which LTP is preparing to execute in next.
Actually this code should be executed only if the test process got stuck
in the kernel and in such case I doubt that there is a value in doing
the cleanup as the cleanup code will likely get stuck there as well.
The rationale is that if process that uses particular mount point is
stuck in the kernel the umount() will likely get stuck there as well and
there is no point in doing anything else than rebooting the machine.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-03-18 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 6:17 [LTP] [PATCH RFC] lib: invoke do_cleanup if failed to kill test processes Li Wang
2019-03-18 12:28 ` Cyril Hrubis [this message]
2019-03-19 12:11 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318122851.GC10187@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox