public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] cpuset: disable for UCLIBC
Date: Mon, 18 Mar 2019 19:19:40 +0100	[thread overview]
Message-ID: <20190318181940.GA5494@dell5510> (raw)
In-Reply-To: <1021cd54-2fbd-5fb9-f374-62761c967331@synopsys.com>

Hi Vineet,

> >> libcpuset.c relies on FTS which is not enabled by default on uClibc.
> >> Instead of needing to reconfigure, rebuild uClibc lets disable this test
> >> for uClibc
> > Which uClibc version are you using?
> > Both uClibc and uclibc-ng has it [1] since 2011, version v0.9.32, in commit
> > a4aa01c12 ("Added fts support for traversing UNIX file hierarchies.")

> Right I'm using bleeding edge as well, and do have the header in sources, its just
> not configured/enabled by default hence not available in installation.


> > It's actually MUSL, what is missing it [2]. Although there is some
> > implementation [3], we should skip it for musl. But the clearest way is really
> > to check presence of <fts.h>, that's fix it for all libc.

> Spot on, that is indeed the best/ideal way of doing it. Do you know if such a
> mechanism already exists in LTP. If you point me to an example I can respin the
> patch accordingly.
Simple adding fts.h in AC_CHECK_HEADERS + guards in a file #ifdef HAVE_FTS_H
should do the magic :).

Kind regards,
Petr

  reply	other threads:[~2019-03-18 18:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 17:44 [LTP] [PATCH] cpuset: disable for UCLIBC Vineet Gupta
2019-03-14 10:01 ` Petr Vorel
2019-03-18 16:41   ` Vineet Gupta
2019-03-18 18:19     ` Petr Vorel [this message]
2019-03-18 19:52       ` [LTP] [PATCH v2] autodetect fts support and tests depending on it Vineet Gupta
2019-03-20 22:37         ` Petr Vorel
2019-03-20 22:47           ` Petr Vorel
2019-03-20 23:11           ` Vineet Gupta
2019-03-21 12:06             ` Petr Vorel
2019-03-21 15:48               ` Vineet Gupta
2019-03-18 20:06       ` [LTP] [PATCH] auto filter aio tests of libc can't support aio Vineet Gupta
2019-03-20 22:48         ` Petr Vorel
2019-03-21 21:43           ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190318181940.GA5494@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox