From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] setpriority01: Skip only PRIO_USER when unable to add test user
Date: Tue, 19 Mar 2019 09:32:10 +0100 [thread overview]
Message-ID: <20190319083210.GB26794@dell5510> (raw)
In-Reply-To: <20190307233154.12873-1-saravanak@google.com>
Hi Saravana,
> We don't need to skip all the tests just because we are unable to add
> a test user. Not having a test user only affects PRIO_USER test case.
> So just skip that one and continue running the rest of the tests when
> useradd is not available.
> If useradd is present and it still fails, then consider it an error in
> the test preparation phase.
> This also allows this test case to be built and run on Android.
> Signed-off-by: Saravana Kannan <saravanak@google.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
...
> v2:
> - Skip only PRIO_USER test when useradd isn't present
> - Fail entire test with TBROK for all other cases where user can't be added
> I still think v1 is the right approach. But if you want TCONF for only
> for cases like Android where useradd itself isn't present, then v2 would
> be the right patch.
Agree with it, but waiting for Cyril approval to merge it.
Kind regards,
Petr
next prev parent reply other threads:[~2019-03-19 8:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 23:31 [LTP] [PATCH v2] setpriority01: Skip only PRIO_USER when unable to add test user Saravana Kannan
2019-03-19 8:32 ` Petr Vorel [this message]
2019-03-19 10:03 ` Cyril Hrubis
2019-03-19 10:28 ` Petr Vorel
2019-03-19 10:31 ` Cyril Hrubis
2019-03-19 11:28 ` Petr Vorel
2019-03-19 20:19 ` Saravana Kannan
-- strict thread matches above, loose matches on Subject: below --
2019-03-07 23:28 Saravana Kannan
2019-03-07 23:31 ` Saravana Kannan
2019-03-19 8:28 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319083210.GB26794@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox