From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] autodetect fts support and tests depending on it
Date: Wed, 20 Mar 2019 23:47:06 +0100 [thread overview]
Message-ID: <20190320224706.GB5619@dell5510> (raw)
In-Reply-To: <20190320223733.GA5619@dell5510>
Hi Vineet,
> > Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> > ---
> > configure.ac | 1 +
> > testcases/kernel/controllers/Makefile | 6 ++++++
> > 2 files changed, 7 insertions(+)
> > diff --git a/configure.ac b/configure.ac
> > index e002c248eab2..10b2f6b1e43b 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -33,6 +33,7 @@ AC_PROG_YACC
> > AC_PREFIX_DEFAULT(/opt/ltp)
> > AC_CHECK_HEADERS([ \
> > + fts.h \
> > ifaddrs.h \
> > keyutils.h \
> > linux/can.h \
> > diff --git a/testcases/kernel/controllers/Makefile b/testcases/kernel/controllers/Makefile
> > index 404073947904..a1626ae03695 100644
> > --- a/testcases/kernel/controllers/Makefile
> > +++ b/testcases/kernel/controllers/Makefile
> > @@ -29,6 +29,12 @@ LIBDIR := libcontrollers
> > LIB := $(LIBDIR)/libcontrollers.a
> > FILTER_OUT_DIRS := $(LIBDIR)
> > +# controllers/cpuset/cpuset_lib/libcpuset.c uses fts
> > +# which may not be available/configured in the libc build
> > +ifndef HAVE_FTS_H
> > +FILTER_OUT_DIRS += cpuset
> > +endif
> Have you tested it? This will not work as HAVE_LIBAIO_H is in include/config.h,
> thus only for C. For Makefile it must be done via autotools (search for AC_SUBST
> in m4/). I thought TST_TEST_TCONF usage, but you're right, that problematic
> source is part of libcontrollers.a (i.e. part of a library, not normal C
> binary).
But when files aren't compiled, they're missing in runtest/controllers (there
are commands expected, that's why we use TST_TEST_TCONF, so file is there but
exits with warning). There is not an elegant solution, maybe adding these missing
binaries into TST_NEEDS_CMDS (one enough to any *.sh).
Kind regards,
Petr
next prev parent reply other threads:[~2019-03-20 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 17:44 [LTP] [PATCH] cpuset: disable for UCLIBC Vineet Gupta
2019-03-14 10:01 ` Petr Vorel
2019-03-18 16:41 ` Vineet Gupta
2019-03-18 18:19 ` Petr Vorel
2019-03-18 19:52 ` [LTP] [PATCH v2] autodetect fts support and tests depending on it Vineet Gupta
2019-03-20 22:37 ` Petr Vorel
2019-03-20 22:47 ` Petr Vorel [this message]
2019-03-20 23:11 ` Vineet Gupta
2019-03-21 12:06 ` Petr Vorel
2019-03-21 15:48 ` Vineet Gupta
2019-03-18 20:06 ` [LTP] [PATCH] auto filter aio tests of libc can't support aio Vineet Gupta
2019-03-20 22:48 ` Petr Vorel
2019-03-21 21:43 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320224706.GB5619@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox