From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] auto filter aio tests of libc can't support aio
Date: Wed, 20 Mar 2019 23:48:33 +0100 [thread overview]
Message-ID: <20190320224833.GA7254@dell5510> (raw)
In-Reply-To: <1552939602-22335-1-git-send-email-vgupta@synopsys.com>
Hi Vineet,
> uClibc-ng lacks libaio.h and thus LTP UCLIBC=1 builds need to filter
> out aio tests which it currently doesn't.
> FWIW the tests sources themselves use a slightly different guard
> HAVE_LIBAIO (while autotool generate HAVE_LIBAIO_H).
> Anyhow that seems pointless as aio tests should not even build of libc
> doesn't support the prerequsute header.
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> ---
> testcases/kernel/io/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/testcases/kernel/io/Makefile b/testcases/kernel/io/Makefile
> index 7db02882a530..3afae3888f63 100644
> --- a/testcases/kernel/io/Makefile
> +++ b/testcases/kernel/io/Makefile
> @@ -24,4 +24,8 @@ top_srcdir ?= ../../..
> include $(top_srcdir)/include/mk/env_pre.mk
> +ifndef HAVE_LIBAIO_H
> +FILTER_OUT_DIRS += aio
> +endif
This is IMHO wrong, as all files using libaio.h are guarded with
TST_TEST_TCONF().
Kind regards,
Petr
next prev parent reply other threads:[~2019-03-20 22:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 17:44 [LTP] [PATCH] cpuset: disable for UCLIBC Vineet Gupta
2019-03-14 10:01 ` Petr Vorel
2019-03-18 16:41 ` Vineet Gupta
2019-03-18 18:19 ` Petr Vorel
2019-03-18 19:52 ` [LTP] [PATCH v2] autodetect fts support and tests depending on it Vineet Gupta
2019-03-20 22:37 ` Petr Vorel
2019-03-20 22:47 ` Petr Vorel
2019-03-20 23:11 ` Vineet Gupta
2019-03-21 12:06 ` Petr Vorel
2019-03-21 15:48 ` Vineet Gupta
2019-03-18 20:06 ` [LTP] [PATCH] auto filter aio tests of libc can't support aio Vineet Gupta
2019-03-20 22:48 ` Petr Vorel [this message]
2019-03-21 21:43 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320224833.GA7254@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox