From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Wed, 20 Mar 2019 23:48:33 +0100 Subject: [LTP] [PATCH] auto filter aio tests of libc can't support aio In-Reply-To: <1552939602-22335-1-git-send-email-vgupta@synopsys.com> References: <20190318181940.GA5494@dell5510> <1552939602-22335-1-git-send-email-vgupta@synopsys.com> Message-ID: <20190320224833.GA7254@dell5510> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Vineet, > uClibc-ng lacks libaio.h and thus LTP UCLIBC=1 builds need to filter > out aio tests which it currently doesn't. > FWIW the tests sources themselves use a slightly different guard > HAVE_LIBAIO (while autotool generate HAVE_LIBAIO_H). > Anyhow that seems pointless as aio tests should not even build of libc > doesn't support the prerequsute header. > Signed-off-by: Vineet Gupta > --- > testcases/kernel/io/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > diff --git a/testcases/kernel/io/Makefile b/testcases/kernel/io/Makefile > index 7db02882a530..3afae3888f63 100644 > --- a/testcases/kernel/io/Makefile > +++ b/testcases/kernel/io/Makefile > @@ -24,4 +24,8 @@ top_srcdir ?= ../../.. > include $(top_srcdir)/include/mk/env_pre.mk > +ifndef HAVE_LIBAIO_H > +FILTER_OUT_DIRS += aio > +endif This is IMHO wrong, as all files using libaio.h are guarded with TST_TEST_TCONF(). Kind regards, Petr