From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] msgrcv/msgrcv08.c: Use struct msgbuf defined in <sys/msg.h>
Date: Thu, 21 Mar 2019 10:51:23 +0100 [thread overview]
Message-ID: <20190321095123.GA1252@rei> (raw)
In-Reply-To: <20190320215707.30268-1-petr.vorel@gmail.com>
Hi!
> which requires to define _GNU_SOURCE.
> This fixes MUSL build.
>
> NOTE: char array from struct has usually length 1, the one from test had 16,
> but that's not a limitation.
>
> Fixes: eccd238da ("ipc/msgrcv: add new testcase msgrcv08")
It does not matter much here, but actually the structure is supposed to
be user defined, see the msgrcv manual page and you are supposed to pick
the message buffer length accordingly to your needs.
I guess that slightly better fix would be renaming the structure name,
the rest of the msgctl tests uses struct mbuf instead.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2019-03-21 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 21:57 [LTP] [PATCH 1/1] msgrcv/msgrcv08.c: Use struct msgbuf defined in <sys/msg.h> Petr Vorel
2019-03-21 9:51 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321095123.GA1252@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox