From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 1/2] tst_test: Add test multiplex function
Date: Mon, 25 Mar 2019 10:50:54 +0100 [thread overview]
Message-ID: <20190325095054.GA10821@dell5510> (raw)
In-Reply-To: <20190322171134.899-2-chrubis@suse.cz>
Hi Cyril,
Nice! Whole patchset LGTM, one typo below.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> +2.2.29 Testing similar syscalls in one test
> +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +In some cases kernel has several very similar syscalls that do either the same
> +or very similar job. This is most noticeable on i386 where we commonly have
> +two or three syscall versions. That is because i386 was first platform that
> +Linux was developed on and because of that most mistakes in API happened there
> +as well. However this is not limited to i386 at all, it's quite common that
> +version two syscall has added missing flags parameters or so.
> +
> +In such cases it does not make much sense to copy&paste the test code over and
> +over, rather than that the test library provides support for test variants.
> +The idea behind test variants is simple, we run the test several times each
> +time with different syscall variant.
> +
> +The implemenation consist of test_variant integer that, if set, denotes number
Typo => implementation
Kind regards,
Petr
next prev parent reply other threads:[~2019-03-25 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 17:11 [LTP] [PATCH v3 0/2] Implement syscall variants Cyril Hrubis
2019-03-22 17:11 ` [LTP] [PATCH v3 1/2] tst_test: Add test multiplex function Cyril Hrubis
2019-03-25 9:50 ` Petr Vorel [this message]
2019-03-22 17:11 ` [LTP] [PATCH v3 2/2] syscalls/select04: Test four syscall variants Cyril Hrubis
2019-03-25 14:20 ` Petr Vorel
2019-03-25 7:06 ` [LTP] [PATCH v3 0/2] Implement " Jan Stancek
2019-03-26 9:39 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325095054.GA10821@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox