From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] sigpending: Use 3 variants via test_multiplex()
Date: Tue, 26 Mar 2019 11:47:20 +0100 [thread overview]
Message-ID: <20190326104719.GA16888@dell5510> (raw)
In-Reply-To: <20190326101022.GA28312@rei>
Hi Cyril,
> Hi!
> > static void run(void)
> > {
> > + sigpending_info();
> > test_sigpending();
> > test_efault_on_invalid_sigset();
> > }
> > static struct tst_test test = {
> > - .test_all = run
> > + .test_all = run,
> > + .test_variants = 3,
> > };
> I would rather see .setup = singpending_info, here so that we don't spam
> the output that much, otherwise it looks good.
No problem, but with the following diff is the output the same. Am I missing
something?
Kind regards,
Petr
+++ testcases/kernel/syscalls/sigpending/sigpending02.c
@@ -151,12 +151,12 @@ static void test_efault_on_invalid_sigset(void)
static void run(void)
{
- sigpending_info();
test_sigpending();
test_efault_on_invalid_sigset();
}
static struct tst_test test = {
+ .setup = sigpending_info,
.test_all = run,
.test_variants = 3,
};
---
tst_test.c:1096: INFO: Timeout per run is 0h 05m 00s
sigpending02.c:24: INFO: Testing libc sigpending()
sigpending02.c:113: PASS: basic sigpending test successful
sigpending02.c:143: PASS: expected failure: EFAULT
tst_test.c:1096: INFO: Timeout per run is 0h 05m 00s
sigpending02.c:27: INFO: Testing __NR_sigpending syscall
sigpending02.c:42: CONF: syscall(-1) __NR_sigpending not supported
tst_test.c:1096: INFO: Timeout per run is 0h 05m 00s
sigpending02.c:30: INFO: Testing __NR_rt_sigpending syscall
sigpending02.c:113: PASS: basic sigpending test successful
sigpending02.c:143: PASS: expected failure: EFAULT
Summary:
passed 4
failed 0
skipped 0
warnings 0
next prev parent reply other threads:[~2019-03-26 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 15:14 [LTP] [PATCH 1/1] sigpending: Use 3 variants via test_multiplex() Petr Vorel
2019-03-26 10:10 ` Cyril Hrubis
2019-03-26 10:47 ` Petr Vorel [this message]
2019-03-26 10:58 ` Cyril Hrubis
2019-03-26 11:02 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326104719.GA16888@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox