From: Petr Vorel <petr.vorel@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [RESENT][PATCH v2 1/1] lapi: Define TST_ABI{, 32, 64} to detect target type
Date: Thu, 28 Mar 2019 07:43:09 +0100 [thread overview]
Message-ID: <20190328064235.GA11011@x230> (raw)
In-Reply-To: <20190327153911.GA9223@rei.lan>
Hi Cyril,
> Hi!
> > and replace __WORDSIZE with them.
> > Motivation was instead of finding, where all libc define __WORDSIZE,
> > which is usually used for detecting target type (at least MUSL
> > defines it in different place than other libc) we define our own
> > constant.
> > + change encoding of the comment in mem01.c to utf8 and use SPDX license
> > identifier.
> This should go in separate patch, also I do not see a reason to keep the
> "We didn't forget you" french comment in the source file, we should
> probably delete it.
> Other than that the rest looks good.
Thanks for your review!
Split into 2 patches and merged.
Kind regards,
Petr
prev parent reply other threads:[~2019-03-28 6:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 10:52 [LTP] [RESENT][PATCH v2 1/1] lapi: Define TST_ABI{, 32, 64} to detect target type Petr Vorel
2019-03-27 15:39 ` Cyril Hrubis
2019-03-28 6:43 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328064235.GA11011@x230 \
--to=petr.vorel@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox