From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically
Date: Thu, 28 Mar 2019 16:24:42 +0100 [thread overview]
Message-ID: <20190328152442.GB6002@x230> (raw)
In-Reply-To: <1553765807-31789-2-git-send-email-yangx.jy@cn.fujitsu.com>
Hi Xiao, Steve,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> diff --git a/m4/ltp-libc-funcs.m4 b/m4/ltp-libc-funcs.m4
> index ebbe2c9..122073f 100644
> --- a/m4/ltp-libc-funcs.m4
> +++ b/m4/ltp-libc-funcs.m4
> @@ -10,5 +10,5 @@ dnl
> AC_DEFUN([LTP_CHECK_LIBC_FUNCS],[
> AC_CHECK_FUNCS(epoll_pwait execveat fallocate fchownat fstatat kcmp mkdirat \
> mknodat openat preadv preadv2 pwritev pwritev2 readlinkat renameat renameat2 \
> -splice syncfs sync_file_range tee unshare vmsplice,,)
> +splice stime syncfs sync_file_range tee unshare vmsplice,,)
I hope AC_CHECK_FUNCS is working well on cross compilation (I guess so, but
noticed some problems on autotools with PKG_CHECK_MODULES, but that's different
as it's using pkg-config).
...
> diff --git a/testcases/kernel/syscalls/stime/stime_var.h b/testcases/kernel/syscalls/stime/stime_var.h
...
> -#ifdef __ANDROID__
> - tst_brk(TCONF, "libc stime() is not implemented on Android");
> +#ifndef HAVE_STIME
> + tst_brk(TCONF, "libc stime() is not implemented");
> #else
> return stime(ntime);
> #endif
Kind regards,
Petr
next prev parent reply other threads:[~2019-03-28 15:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 9:36 [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Xiao Yang
2019-03-28 9:36 ` [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically Xiao Yang
2019-03-28 15:24 ` Petr Vorel [this message]
2019-03-29 3:19 ` Xiao Yang
2019-04-17 17:10 ` Petr Vorel
2019-03-28 14:56 ` [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Petr Vorel
2019-03-28 15:12 ` Petr Vorel
2019-04-04 10:31 ` Cyril Hrubis
2019-04-04 11:58 ` Petr Vorel
2019-04-05 3:15 ` Xiao Yang
2019-04-05 7:13 ` Petr Vorel
2019-04-05 7:32 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328152442.GB6002@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox