From: Sandeep Patil <sspatil@android.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 1/4] syscalls/abort01: convert to new library
Date: Wed, 3 Apr 2019 08:49:31 -0700 [thread overview]
Message-ID: <20190403154931.GC174313@google.com> (raw)
In-Reply-To: <20190403120653.GC13658@rei>
On Wed, Apr 03, 2019 at 02:06:53PM +0200, Cyril Hrubis wrote:
> Hi!
> > > > I am surprised that didn't throw a warning + build error for me.
> > > > other than that, thanks for doing this
> > >
> > > That depends on gcc version and mix of warning flags...
> >
> > clang actually throws a lot of warnings for us when we build it natively for
> > Android. In this case however, I just used my laptop "gcc (Debian 7.3.0-5)"
> > and default flags for LTP builds.
> >
> > Do you have plans of enabling -Werror?
>
> We cannot do that with the amount of legacy code we have the build would
> fail pretty much every time. So no, no plans for the foreseeable future.
Ack, thanks Cyril. I'd rather convert as many tests to the new library before
I get to them then. By the way, I sent V2s for acct01 & accept01 addressing
your comments now.
- ssp
next prev parent reply other threads:[~2019-04-03 15:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 23:20 [LTP] [PATCH 0/4] Convert tests to use new library Sandeep Patil
2019-03-25 23:20 ` [LTP] [RFC PATCH 1/4] syscalls/abort01: convert to " Sandeep Patil
2019-03-26 11:58 ` Cyril Hrubis
2019-03-26 12:47 ` Sandeep Patil
2019-03-26 12:51 ` Cyril Hrubis
2019-03-28 4:07 ` Sandeep Patil
2019-04-03 12:06 ` Cyril Hrubis
2019-04-03 15:49 ` Sandeep Patil [this message]
2019-03-25 23:20 ` [LTP] [PATCH 2/4] syscalls/accept01: " Sandeep Patil
2019-03-26 12:35 ` Cyril Hrubis
2019-03-26 12:44 ` Sandeep Patil
2019-03-25 23:20 ` [LTP] [PATCH 3/4] syscalls/accept4: " Sandeep Patil
2019-03-26 15:33 ` Cyril Hrubis
2019-03-25 23:20 ` [LTP] [PATCH 4/4] syscalls/acct01: " Sandeep Patil
2019-03-26 16:11 ` Cyril Hrubis
2019-03-26 9:42 ` [LTP] [PATCH 0/4] Convert tests to use " Cyril Hrubis
2019-03-26 12:48 ` Sandeep Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403154931.GC174313@google.com \
--to=sspatil@android.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox