public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations
Date: Thu, 4 Apr 2019 12:31:31 +0200	[thread overview]
Message-ID: <20190404103131.GB20565@rei.lan> (raw)
In-Reply-To: <20190328151228.GA6002@x230>

Hi!
> > +++ b/m4/ltp-libc-funcs.m4
> > @@ -0,0 +1,14 @@
> > +dnl SPDX-License-Identifier: GPL-2.0-or-later
> > +dnl Copyright (c) 2019 Fujitsu Ltd.
> > +dnl Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
> > +
> > +dnl
> > +dnl LTP_CHECK_LIBC_FUNCS
> > +dnl ----------------------------
> > +dnl
> > +
> > +AC_DEFUN([LTP_CHECK_LIBC_FUNCS],[
> > +AC_CHECK_FUNCS(epoll_pwait execveat fallocate fchownat fstatat kcmp mkdirat \
> > +mknodat openat preadv preadv2 pwritev pwritev2 readlinkat renameat renameat2 \
> > +splice syncfs sync_file_range tee unshare vmsplice,,)
> > +])
> Note about formatting: maybe it'd be easier to edit the file if each function
> was on separate line.

Agreed, also we have AC_CHECK_FUNCS() in the configure.ac so the best
step would be moving these there as well.

Other than that this is a great cleanup, thanks for doing this.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2019-04-04 10:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28  9:36 [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Xiao Yang
2019-03-28  9:36 ` [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically Xiao Yang
2019-03-28 15:24   ` Petr Vorel
2019-03-29  3:19     ` Xiao Yang
2019-04-17 17:10       ` Petr Vorel
2019-03-28 14:56 ` [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Petr Vorel
2019-03-28 15:12 ` Petr Vorel
2019-04-04 10:31   ` Cyril Hrubis [this message]
2019-04-04 11:58     ` Petr Vorel
2019-04-05  3:15       ` Xiao Yang
2019-04-05  7:13         ` Petr Vorel
2019-04-05  7:32           ` Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190404103131.GB20565@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox