From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Hrubis <chrubis@suse.cz>
Date: Fri, 12 Apr 2019 10:49:32 +0200
Subject: [LTP] [RFC PATCH 2/3] Add more missing <string.h> and
 <strings.h> includes
In-Reply-To: <b9e58aac-eb0f-965a-c411-ef44c6a3ef27@xiaopeng.com>
References: <20190411233115.32744-1-pvorel@suse.cz>
 <20190411233115.32744-3-pvorel@suse.cz>
 <b9e58aac-eb0f-965a-c411-ef44c6a3ef27@xiaopeng.com>
Message-ID: <20190412084932.GA28648@haruka.lan>
List-Id: <ltp.lists.linux.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ltp@lists.linux.it

Hi!
> > diff --git a/include/tst_numa.h b/include/tst_numa.h
> > index a4cd1be37..4f9806602 100644
> > --- a/include/tst_numa.h
> > +++ b/include/tst_numa.h
> > @@ -7,6 +7,8 @@
> >   #ifndef TST_NUMA_H__
> >   #define TST_NUMA_H__
> >   
> > +#include <string.h>
> > +
> >   /**
> >    * Numa nodemap.
> >    */
> > diff --git a/lib/tst_af_alg.c b/lib/tst_af_alg.c
> > index 97be548b4..edf8c0140 100644
> > --- a/lib/tst_af_alg.c
> > +++ b/lib/tst_af_alg.c
> > @@ -5,6 +5,7 @@
> >   
> >   #include <errno.h>
> >   #include <stdlib.h>
> > +#include <string.h>
> 
> Why not simply include <string.h>?? in tst_test.h. I did it in my another 
> review thread. This should be OK for most of cases.

Sounds reasonable to me.

-- 
Cyril Hrubis
chrubis@suse.cz