From: Sandeep Patil <sspatil@android.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1] rt_tgsigqueueinfo01.c: replace definition ANDROID with __ANDROID__
Date: Fri, 12 Apr 2019 12:49:21 -0700 [thread overview]
Message-ID: <20190412194921.GF124555@google.com> (raw)
In-Reply-To: <ee2af517-8cb1-de29-0ec1-a16818087d0b@xiaopeng.com>
On Fri, Apr 12, 2019 at 11:36:46PM +0800, 阮正旺 wrote:
> Hi Petr, Sandeep, Steve,
>
>
> -------- Original Message --------
> From: Petr Vorel
> Sent: Thu, 11 Apr 2019 19:46:38 +0200
> To: Zhengwang Ruan, Steve Muckle, Sandeep Patil
> Cc: Ltp
> Subject: Re: [LTP] [PATCH v1] rt_tgsigqueueinfo01.c: replace definition
> ANDROID with __ANDROID__
> > Hi,
> >
> > > Replace the incorrect definition of ANDROID with __ANDROID__.
> > > +++ b/testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c
> > > @@ -25,7 +25,7 @@
> > > #include "tst_test.h"
> > > #include "lapi/syscalls.h"
> > > -#ifndef ANDROID
> > > +#ifndef __ANDROID__
> > Simple grep in AOSP tree would be for this change (and I'd personally prefer it as well)
> > I'd kindly ask android devs which one is correct :). BTW ANDROID was added by Steve.
>
> According to also [1], this patch is acceptable, right?
Yes, indeed.
Acked-by: Sandeep Patil <sspatil@android.com>
next prev parent reply other threads:[~2019-04-12 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 14:26 [LTP] [PATCH v1] rt_tgsigqueueinfo01.c: replace definition ANDROID with __ANDROID__ Zhengwang Ruan
2019-04-11 17:46 ` Petr Vorel
2019-04-12 15:36 ` =?unknown-8bit?b?6Ziu5q2j5pe6?=
2019-04-12 19:49 ` Sandeep Patil [this message]
2019-04-14 10:11 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412194921.GF124555@google.com \
--to=sspatil@android.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox