[LTP] 回复：[PATCH v1] include/mk/env_post.mk: enable __ANDROID__ definition for Android build

Petr Vorel
2019-04-23T20:38:55Z

Hi Zhengwang,

> -------- Original Message --------
> From: Petr Vorel
> Sent: Mon, 22 Apr 2019 00:10:30 +0200
> To: Zhengwang Ruan
> Cc: Sandeep Patil, Ltp, Steve Muckle
> Subject: Re: [LTP] 回复：[PATCH v1] include/mk/env_post.mk : enable
> __ANDROID__ definition for Android build
> > Hi Sandeep, Zhengwang,

> > > > I don't know why autotools fails preadv and pwritev detection with AC_CHECK_FUNCS.
> > > > I considered it as problem of my setup, but maybe it's an autotools bug.
> > > I also encountered this issue, but I temporarily walked around it by
> > > applying the following patch.
> > > ==================
> > > $ git diff testcases/
> > > diff --git a/testcases/commands/ldd/datafiles/Makefile
> > > b/testcases/commands/ldd/datafiles/Makefile
> > > index d8bcf5c..74fbe50 100644
> > > --- a/testcases/commands/ldd/datafiles/Makefile
> > > +++ b/testcases/commands/ldd/datafiles/Makefile
> > > @@ -30,7 +30,7 @@ CLEAN_TARGETS         += *.obj $(LDD_SO_FILES)
> > >         $(CC) $(CFLAGS) -shared -o $@ $^
> > >  lddfile.out: main.o $(LDD_SO_FILES)
> > > -       $(CC) $(CFLAGS) -O -o $@ $?
> > > +       $(CC) $(CFLAGS) $(LDFLAGS) -O -o $@ $?
> > What is this change for?

> This is a really long story. In my build, I need to use '-nostdlib
> /ndk/path/to/crtend_android.o /ndk/path/to/crtbegin_dynamic.o' as linker
> arguments to cross-compile, and I have to put these arguments into LDFLAGS
> since there were other errors occurred on linking *.o to executable if I put
> them into CFLAGS.

> Right here, lddfile.out is an executable and obviously needed to be linked,
> therefore LDFLAGS must be required in my case.

Thanks for info. Feel free to send a patch with a long description.

Back to the patch: I'm willing to merge it, just wait if any from Sandeep or
Steve (or any other android developer) will ack it.

Kind regards,
Petr