From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1] include/mk/env_post.mk: enable __ANDROID__ definition for Android build
Date: Wed, 24 Apr 2019 22:19:51 +0200 [thread overview]
Message-ID: <20190424201951.GA26076@x230> (raw)
In-Reply-To: <edc171bb-7351-1069-5a80-8b5c67547fa5@google.com>
Hi Steve, Zhengwang,
> Using Sandeep's instructions and with your latest merged fixes I was able to
> build unmodified upstream with the NDK. I just tried running one of the test
> binaries on my device to sanity check it.
> I put in an #error if __ANDROID__ is defined and it does look to be set by
> the NDK compiler. FWIW I am using Android API level 26, the minimum which
> provides hasmntopt. This gets configured in the "Set up ndk toolchains for
> autoconf" step Sandeep mentioned by setting the CC and CXX env vars
> appropriately.
Thanks for testing. IMHO this is a simple proof that this patch (-D__ANDROID__)
is not needed.
...
> > In the case of cross-compilation, I think it still makes sense, since
> > we can use the same toolchain, such as clang, and build parameters
> > (the specify the include headers and libs, etc) as AOSP.
> but it's not clear to me since you need to have bionic around anyway, and at
> that point, why not just use the Android toolchain?
No, you're right, that does not make sense.
> thanks,
> Steve
Kind regards,
Petr
next prev parent reply other threads:[~2019-04-24 20:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 4:05 [LTP] [PATCH v1] include/mk/env_post.mk: enable __ANDROID__ definition for Android build Zhengwang Ruan
2019-04-09 16:45 ` [LTP] 回复：[PATCH " =?unknown-8bit?b?6Ziu5q2j5pe6?=
2019-04-10 14:16 ` Petr Vorel
2019-04-11 3:38 ` =?unknown-8bit?b?6Ziu5q2j5pe6?=
2019-04-11 16:27 ` Sandeep Patil
2019-04-11 17:37 ` Petr Vorel
2019-04-11 23:40 ` Petr Vorel
2019-04-12 4:45 ` =?unknown-8bit?b?6Ziu5q2j5pe6?=
2019-04-12 6:28 ` Petr Vorel
2019-04-12 16:15 ` =?unknown-8bit?b?6Ziu5q2j5pe6?=
2019-04-12 19:48 ` Sandeep Patil
2019-04-16 12:27 ` =?unknown-8bit?b?6Ziu5q2j5pe6?=
2019-04-17 16:39 ` Sandeep Patil
2019-04-17 17:06 ` Petr Vorel
2019-04-19 15:49 ` =?unknown-8bit?b?6Ziu5q2j5pe6?=
2019-04-21 22:10 ` Petr Vorel
2019-04-23 17:28 ` =?unknown-8bit?b?6Ziu5q2j5pe6?=
2019-04-23 20:38 ` Petr Vorel
2019-04-12 3:09 ` =?unknown-8bit?b?6Ziu5q2j5pe6?=
2019-04-24 9:14 ` [LTP] [PATCH " Petr Vorel
2019-04-24 19:23 ` Steve Muckle
2019-04-24 20:19 ` Petr Vorel [this message]
2019-04-25 3:08 ` =?unknown-8bit?b?6Ziu5q2j5pe6?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424201951.GA26076@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox