From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] OVL_MNT: put overlayfs lower, upper, work, mnt dir in separated mountpoint
Date: Fri, 3 May 2019 23:00:05 +0200 [thread overview]
Message-ID: <20190503210005.GA18171@x230> (raw)
In-Reply-To: <20190430043957.479-1-xzhou@redhat.com>
Hi,
Acked-by: Petr Vorel <pvorel@suse.cz>
> testcases/kernel/syscalls/inotify/inotify07.c | 24 +++++++++++------
> -#define OVL_MNT "ovl"
> +#define MNTPOINT "mntpoint"
> +#define OVL_LOWER MNTPOINT"/lower"
> +#define OVL_UPPER MNTPOINT"/upper"
> +#define OVL_WORK MNTPOINT"/work"
> +#define OVL_MNT MNTPOINT"/ovl"
> +
> #define TEST_APP "execveat_child"
> #define TEST_FILE_PATH OVL_MNT"/"TEST_APP
> +static const char mntpoint[] = MNTPOINT;
> +
> static int ovl_mounted;
> static void do_child(void)
> @@ -91,12 +98,12 @@ static void setup(void)
> check_execveat();
> /* Setup an overlay mount with lower file */
> - SAFE_MKDIR("lower", 0755);
> - SAFE_MKDIR("upper", 0755);
> - SAFE_MKDIR("work", 0755);
> + SAFE_MKDIR(OVL_LOWER, 0755);
> + SAFE_MKDIR(OVL_UPPER, 0755);
> + SAFE_MKDIR(OVL_WORK, 0755);
> SAFE_MKDIR(OVL_MNT, 0755);
NOTE: Maybe it'd be worth of adding some helper to define these constants and creating this setup (in separate commit).
Kind regards,
Petr
next prev parent reply other threads:[~2019-05-03 21:00 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 4:39 [LTP] [PATCH] OVL_MNT: put overlayfs lower, upper, work, mnt dir in separated mountpoint Murphy Zhou
2019-04-30 8:18 ` Li Wang
2019-05-03 21:00 ` Petr Vorel [this message]
2019-05-15 9:21 ` [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper Murphy Zhou
2019-05-15 9:21 ` [LTP] [PATCH v2 2/2] OVL_MNT: put overlayfs lower, upper, work, mnt dir in a separated mountpoint Murphy Zhou
2019-05-15 13:39 ` Petr Vorel
2019-05-16 9:14 ` Murphy Zhou
2019-05-15 13:31 ` [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper Petr Vorel
2019-05-15 13:42 ` Petr Vorel
2019-05-15 14:30 ` Amir Goldstein
2019-05-15 18:20 ` Petr Vorel
2019-05-16 9:15 ` Murphy Zhou
2019-05-24 4:48 ` Murphy Zhou
2019-05-24 7:30 ` Petr Vorel
2019-05-24 9:04 ` [LTP] [PATCH v3 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Murphy Zhou
2019-05-24 9:04 ` [LTP] [PATCH v3 2/2] OVL_MNT: setup overlayfs dirs and mount in a separated mountpoint Murphy Zhou
2019-05-24 4:32 ` [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper Murphy Zhou
2019-05-24 8:54 ` Petr Vorel
2019-05-24 11:24 ` Amir Goldstein
2019-05-24 12:23 ` Petr Vorel
2019-05-24 13:44 ` Murphy Zhou
2019-05-25 11:51 ` [LTP] [PATCH v4 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Murphy Zhou
2019-05-25 11:51 ` [LTP] [PATCH v4 2/2] OVL_MNT: setup overlayfs dirs and mount in a separated mountpoint Murphy Zhou
2019-05-27 12:09 ` [LTP] [PATCH v4 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Petr Vorel
2019-05-27 13:17 ` Amir Goldstein
2019-05-27 15:27 ` Petr Vorel
2019-05-27 13:38 ` Murphy Zhou
2019-05-27 15:36 ` Petr Vorel
2019-05-29 7:49 ` Murphy Zhou
2019-05-29 10:18 ` [LTP] [PATCH v5 " Murphy Zhou
2019-05-29 10:18 ` [LTP] [PATCH v5 2/2] OVL_MNT: setup overlayfs dirs and mount in a separated mountpoint Murphy Zhou
2019-05-29 10:55 ` Amir Goldstein
2019-05-29 10:59 ` [LTP] [PATCH v5 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Amir Goldstein
2019-05-30 2:41 ` Murphy Zhou
2019-05-30 2:53 ` [LTP] [PATCH v6 " Murphy Zhou
2019-05-30 2:53 ` [LTP] [PATCH v6 2/2] OVL_MNT: setup overlayfs dirs and mount in a separated mountpoint Murphy Zhou
2019-06-03 7:12 ` Petr Vorel
2019-06-03 5:06 ` [LTP] [PATCH v6 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Petr Vorel
2019-05-24 13:36 ` [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper Murphy Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503210005.GA18171@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox