From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] numa: fix numa test error with non-continuous nodes
Date: Tue, 14 May 2019 17:06:20 +0200 [thread overview]
Message-ID: <20190514150619.GA4394@rei.lan> (raw)
In-Reply-To: <CAEemH2e6WURWFkMneL6vdEwPpbwxj0Lt=HjpfSYdyzxnhGdODQ@mail.gmail.com>
Hi!
> > diff --git a/testcases/kernel/numa/numa01.sh
> > b/testcases/kernel/numa/numa01.sh
> > index 33393ac8d..47c18edd6 100755
> > --- a/testcases/kernel/numa/numa01.sh
> > +++ b/testcases/kernel/numa/numa01.sh
> > @@ -94,6 +94,7 @@ setup()
> > test1()
> > {
> > Mem_curr=0
> > + node_index=0
> >
> > for node in $nodes_list; do
> > numactl --cpunodebind=$node --membind=$node support_numa
> > alloc_1MB &
> > @@ -101,7 +102,8 @@ test1()
> >
> > TST_RETRY_FUNC "check_for_support_numa $pid" 0
> >
> > - Mem_curr=$(echo "$(extract_numastat_p $pid $node) * $MB"
> > |bc)
> > + Mem_curr=$(echo "$(extract_numastat_p $pid $node_index) *
> > $MB" |bc)
> > + let node_index++
> >
>
> I guess it can be work, but the disadvantage of that is we have to involve
> a new variable(node_index) in each of the tests (from test1 to test10).
> Hence I don't think it is much better than my patch. For which way to go,
> I'd leave this to Cyril to make a choice. Or, maybe he has different
> thoughts on this:).
I actually do not care that much about the numa01.sh tests, because
these are broken in more ways than this and were never correct to begin
with.
I've started to rewrite these into proper tests, the set_mempolicy() was
first part of that effort, the mbind() tests are continuation of that
and the end goal is to get rid of these broken tests eventually.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-05-14 15:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 8:44 [LTP] [PATCH v2 1/2] numa: fix numa test error with non-continuous nodes Li Wang
2019-05-08 8:44 ` [LTP] [PATCH v2 2/2] libltpnuma: remove restrictions on numa node-id Li Wang
2019-05-09 6:45 ` Balamuruhan S
2019-05-09 8:00 ` Li Wang
2019-05-09 9:23 ` Balamuruhan S
2019-05-09 15:50 ` Jan Stancek
2019-05-14 14:30 ` Cyril Hrubis
2019-05-09 7:16 ` [LTP] [PATCH v2 1/2] numa: fix numa test error with non-continuous nodes Balamuruhan S
2019-05-09 7:54 ` Li Wang
2019-05-09 9:19 ` Balamuruhan S
2019-05-09 10:00 ` Li Wang
2019-05-14 15:06 ` Cyril Hrubis [this message]
2021-11-10 10:54 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514150619.GA4394@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox