From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] ltp-cap.m4: add libcap version detection && fix compiler error
Date: Wed, 15 May 2019 16:37:46 +0200 [thread overview]
Message-ID: <20190515143746.GA7507@dell5510> (raw)
In-Reply-To: <5CDBD564.8010300@cn.fujitsu.com>
Hi Yang,
> > > At the beginning, I
> > > think it makes no sense because libcap-1 is too old. But I notices that ltp-quota.m4
> > > has quota_v1 and quota_v2. I changes my mind.
> > > Since we have drop libnuma v1, I agree with you that we also drop libcap v1(too old).
> > > Also, I think we should drop quota_v1 because it is too old (since Linux 2.4.22, Q_GETINFO has
> > > been supported in kernel).
> > Good point. But I'm not sure if it's the same, as QFMT_VFS_OLD is part of kernel
> > source tree (part of kernel space code) so it makes sense to test it, whereas
> > libcap v1 and libnuma v1 are just old versions of user space library.
> > Or am I wrong?
> Hi Petr
> I have seen kernel source about quota and try it. I think you are right. But current quota_v1
> and quota_v2 detection has problem. In kernel source, I disable CONFIG_QFMT_V2 and enable CONFIG_QFMT_V1
> ,then I found ltp still detects quotav2 instead of quotav1, and run ./quotactl01, the following error occurs:
LTP detection in ltp-quota.m4 defines _LINUX_QUOTA_VERSION for detection.
I guess you'd have to define HAVE_QUOTAV1 and undefine HAVE_QUOTAV2 in in
include/config.h, but not tested.
BTW _LINUX_QUOTA_VERSION was removed from glibc in 2.25 [1] [2], which based setup
on <linux/quota.h>. And musl defines only _LINUX_QUOTA_VERSION 2.
Regards man info that v1 is from kernel v2.4.22 we should probably also remove
it's support.
We got a bit away from libcap :).
Kind regards,
Petr
[1] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=4d728087ef8cc826b05bd21d0c74d4eca9b1a27d;hp=de6b6d14e9b4d8e9a7333addca55163d9ebb7ff6
[2] https://patchwork.ozlabs.org/patch/664156/
next prev parent reply other threads:[~2019-05-15 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 7:26 [LTP] [PATCH] ltp-cap.m4: add libcap version detection && fix compiler error Yang Xu
2019-05-13 13:14 ` Petr Vorel
2019-05-14 5:24 ` xuyang
2019-05-14 12:01 ` Petr Vorel
2019-05-15 9:01 ` xuyang
2019-05-15 14:37 ` Petr Vorel [this message]
2019-05-16 6:44 ` xuyang
2019-05-16 6:52 ` [LTP] [PATCH v2] security: add missing PR_CAPBSET_READ/PR_CAPBSET_DROP check Yang Xu
2019-06-20 11:49 ` Petr Vorel
2019-06-21 2:01 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515143746.GA7507@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox