From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper
Date: Wed, 15 May 2019 20:20:57 +0200 [thread overview]
Message-ID: <20190515182057.GA1856@x230> (raw)
In-Reply-To: <CAOQ4uxhaSBiKY7nLNnbvpc7mpcnyOJ8Ecf3Es8n_VTPBRnfF7g@mail.gmail.com>
Hi Amir, Murphy,
> I liked your idea of create_overlay_dirs/mount_overlay better.
> It is more flexible for future tests that may want to umount and
> mount overlay several times and the setup of lower/upper files
> could be very different in future tests, not limited to just creating
> files (maybe symlinks, xattr).
> The experience from xfstests overlay tests suggests that the
> create_overlay_dirs/mount_overlay helpers are a good model to follow.
Thanks for ideas, agree with it.
Other thing is to have const char *file, const int lineno as first parameters
for mount_overlay_() and create mount_overlay() and SAFE_MOUNT_OVERLAY() as macros,
which would use it. See tst_mkfs{_,}() as examples.
> Thanks,
> Amir.
Kind regards,
Petr
next prev parent reply other threads:[~2019-05-15 18:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 4:39 [LTP] [PATCH] OVL_MNT: put overlayfs lower, upper, work, mnt dir in separated mountpoint Murphy Zhou
2019-04-30 8:18 ` Li Wang
2019-05-03 21:00 ` Petr Vorel
2019-05-15 9:21 ` [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper Murphy Zhou
2019-05-15 9:21 ` [LTP] [PATCH v2 2/2] OVL_MNT: put overlayfs lower, upper, work, mnt dir in a separated mountpoint Murphy Zhou
2019-05-15 13:39 ` Petr Vorel
2019-05-16 9:14 ` Murphy Zhou
2019-05-15 13:31 ` [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper Petr Vorel
2019-05-15 13:42 ` Petr Vorel
2019-05-15 14:30 ` Amir Goldstein
2019-05-15 18:20 ` Petr Vorel [this message]
2019-05-16 9:15 ` Murphy Zhou
2019-05-24 4:48 ` Murphy Zhou
2019-05-24 7:30 ` Petr Vorel
2019-05-24 9:04 ` [LTP] [PATCH v3 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Murphy Zhou
2019-05-24 9:04 ` [LTP] [PATCH v3 2/2] OVL_MNT: setup overlayfs dirs and mount in a separated mountpoint Murphy Zhou
2019-05-24 4:32 ` [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper Murphy Zhou
2019-05-24 8:54 ` Petr Vorel
2019-05-24 11:24 ` Amir Goldstein
2019-05-24 12:23 ` Petr Vorel
2019-05-24 13:44 ` Murphy Zhou
2019-05-25 11:51 ` [LTP] [PATCH v4 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Murphy Zhou
2019-05-25 11:51 ` [LTP] [PATCH v4 2/2] OVL_MNT: setup overlayfs dirs and mount in a separated mountpoint Murphy Zhou
2019-05-27 12:09 ` [LTP] [PATCH v4 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Petr Vorel
2019-05-27 13:17 ` Amir Goldstein
2019-05-27 15:27 ` Petr Vorel
2019-05-27 13:38 ` Murphy Zhou
2019-05-27 15:36 ` Petr Vorel
2019-05-29 7:49 ` Murphy Zhou
2019-05-29 10:18 ` [LTP] [PATCH v5 " Murphy Zhou
2019-05-29 10:18 ` [LTP] [PATCH v5 2/2] OVL_MNT: setup overlayfs dirs and mount in a separated mountpoint Murphy Zhou
2019-05-29 10:55 ` Amir Goldstein
2019-05-29 10:59 ` [LTP] [PATCH v5 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Amir Goldstein
2019-05-30 2:41 ` Murphy Zhou
2019-05-30 2:53 ` [LTP] [PATCH v6 " Murphy Zhou
2019-05-30 2:53 ` [LTP] [PATCH v6 2/2] OVL_MNT: setup overlayfs dirs and mount in a separated mountpoint Murphy Zhou
2019-06-03 7:12 ` Petr Vorel
2019-06-03 5:06 ` [LTP] [PATCH v6 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Petr Vorel
2019-05-24 13:36 ` [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper Murphy Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515182057.GA1856@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox