public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] lib: Migrate tst_get_unused_port to new API
Date: Mon, 20 May 2019 16:50:02 +0200	[thread overview]
Message-ID: <20190520145002.GA28760@dell5510> (raw)
In-Reply-To: <20190520141940.GB28976@rei.lan>

Hi,

> Hi!
> Acked.
Thanks.

I'm sorry, current implementation is wrong as it does not print port :).
I'll push it with this diff (I guess we don't need new line for port,
although that's not problematic for shell usage like this:

port=$(tst_get_unused_port ipv${TST_IPVER} stream)

Kind regards,
Petr

--- a/testcases/lib/tst_get_unused_port.c
+++ b/testcases/lib/tst_get_unused_port.c
@@ -54,5 +54,6 @@ int main(int argc, char *argv[])
 		return 1;
 	}
 
-	return TST_GET_UNUSED_PORT(family, type);
+	printf("%d", TST_GET_UNUSED_PORT(family, type));
+	return 0;
 }

  reply	other threads:[~2019-05-20 14:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 13:54 [LTP] [PATCH] lib: Migrate tst_get_unused_port to new API Petr Vorel
2019-05-20 14:19 ` Cyril Hrubis
2019-05-20 14:50   ` Petr Vorel [this message]
2019-05-20 15:18     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520145002.GA28760@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox