From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] shmctl01: don't use hardcoded index == 0 for SHM_STAT test
Date: Mon, 20 May 2019 21:58:05 +0200 [thread overview]
Message-ID: <20190520195805.GA22932@x230> (raw)
In-Reply-To: <a5e65ca65d88177d9142cbd2d5a3ddf5dda174b5.1558379215.git.jstancek@redhat.com>
Hi Jan,
> Test fails on SHM_STAT testcase:
> shmctl01 5 TFAIL : shmctl01.c:173: shmctl01 call failed
> errno = 22 : Invalid argument
> shmctl(0, SHM_STAT, 0x601060) = -EINVAL
> since following commit:
> commit 99db46ea292780cd978d56932d9445b1e8bdafe8
> Author: Manfred Spraul <manfred@colorfullife.com>
> Date: Tue May 14 15:46:36 2019 -0700
> ipc: do cyclic id allocation for the ipc object.
> Don't rely on index 0 being always available, but instead
> use (maximum) index returned by SHM_INFO.
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Good catch + further improvements.
Kind regards,
Petr
next prev parent reply other threads:[~2019-05-20 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 19:08 [LTP] [PATCH] shmctl01: don't use hardcoded index == 0 for SHM_STAT test Jan Stancek
2019-05-20 19:58 ` Petr Vorel [this message]
2019-05-21 9:58 ` Cyril Hrubis
2019-05-21 13:49 ` Jan Stancek
2019-05-21 14:10 ` Petr Vorel
2019-05-21 16:02 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520195805.GA22932@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox