public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Sandeep Patil <sspatil@android.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 1/1] open_posix_testsuite/pthread_sigmask: fix return value checks
Date: Tue, 21 May 2019 12:40:01 +0800	[thread overview]
Message-ID: <20190521044001.GB7753@google.com> (raw)
In-Reply-To: <20190520095356.GB25405@rei.lan>

On Mon, May 20, 2019 at 11:53:57AM +0200, Cyril Hrubis wrote:
> Hi!
> > Consistently use error(3) and replace all occurences of perror()
> > at the same time.
> 
> The error(3) is GNU extension we cannot use it in a POSIX testsuite as
> such, I guess that we will have to add custom error reporting functions
> (in a separate patch) to the open_posix_testsuite/include/posixtest.h
> header...
> 
> Other than that the patch is obviously correct.

Thanks you want me to add an error(3)-like function there?
I guess I can do that and then start changing all tests.

Thanks for pointing out the GNU-extension, didn't realize that.

- ssp

  reply	other threads:[~2019-05-21  4:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20  4:17 [LTP] [RFC PATCH 0/1] Fix return value checks for posix apis Sandeep Patil
2019-05-20  4:17 ` [LTP] [RFC PATCH 1/1] open_posix_testsuite/pthread_sigmask: fix return value checks Sandeep Patil
2019-05-20  9:53   ` Cyril Hrubis
2019-05-21  4:40     ` Sandeep Patil [this message]
2019-05-21 11:46       ` Cyril Hrubis
2019-05-20  9:49 ` [LTP] [RFC PATCH 0/1] Fix return value checks for posix apis Cyril Hrubis
2019-05-21  4:41   ` Sandeep Patil
2019-05-21 11:48     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521044001.GB7753@google.com \
    --to=sspatil@android.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox