From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4] syscalls/copy_file_range: add/restructured tests
Date: Tue, 21 May 2019 13:40:40 +0200 [thread overview]
Message-ID: <20190521114040.GB13910@rei> (raw)
In-Reply-To: <CAOQ4uxivgpoMeUUxm-fboFfiXLXn+QXNzKJWSHAZhidwUsuvng@mail.gmail.com>
Hi!
> > > > 2) Glibc adds internal implementation of copy_file_range(), used as fallback
> > > > when kernel < 4.5 (which brought copy_file_range()) [1]. I guess there is no way
> > > > to use it explicitly :(.
> >
> > > Well we can always use filesystem that does not support the operation,
> > > so running the test for all filesystems should get the emulation covered
> > > for sure...
> > Oh, that's the way :).
>
> Actually, there is no such thing as filesystem that does not support
> copy_file_range() because the kernel provides a fallback default implementation
> (in-kernel copy).
So the glibc fallback code is probably something that will end up being
used if someone wants to run application that uses this syscall on BSD
or other corner cases. I guess that we do not care that much about
testing the glibc fallback code then.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-05-21 11:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 10:54 [LTP] [PATCH v4] syscalls/copy_file_range: add/restructured tests Christian Amann
2019-05-06 10:57 ` Christian Amann
2019-05-06 20:19 ` Petr Vorel
2019-05-20 14:31 ` Petr Vorel
2019-05-20 14:46 ` Cyril Hrubis
2019-05-20 15:24 ` Petr Vorel
2019-05-20 16:45 ` Amir Goldstein
2019-05-20 17:30 ` Petr Vorel
2019-05-21 11:40 ` Cyril Hrubis [this message]
2019-05-21 12:50 ` Amir Goldstein
2019-05-21 13:08 ` Cyril Hrubis
2019-05-22 19:03 ` Petr Vorel
2019-05-23 8:44 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521114040.GB13910@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox