From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 1/1] open_posix_testsuite/pthread_sigmask: fix return value checks
Date: Tue, 21 May 2019 13:46:29 +0200 [thread overview]
Message-ID: <20190521114629.GC13910@rei> (raw)
In-Reply-To: <20190521044001.GB7753@google.com>
Hi!
> > The error(3) is GNU extension we cannot use it in a POSIX testsuite as
> > such, I guess that we will have to add custom error reporting functions
> > (in a separate patch) to the open_posix_testsuite/include/posixtest.h
> > header...
> >
> > Other than that the patch is obviously correct.
>
> Thanks you want me to add an error(3)-like function there?
> I guess I can do that and then start changing all tests.
If you think that error(3) like API is best fit then we can go ahead and
use it for posix testsuite. You can also think about it a bit and maybe
create something that will fit the purpose slightly better.
Only thing I would have avoided is to give the function names that are
likely to collide with test code. I would expect that there are several
tests that use error as a variable, so if we decide to name the function
that way we should prefix it with pts_ e.g. pts_error().
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-05-21 11:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 4:17 [LTP] [RFC PATCH 0/1] Fix return value checks for posix apis Sandeep Patil
2019-05-20 4:17 ` [LTP] [RFC PATCH 1/1] open_posix_testsuite/pthread_sigmask: fix return value checks Sandeep Patil
2019-05-20 9:53 ` Cyril Hrubis
2019-05-21 4:40 ` Sandeep Patil
2019-05-21 11:46 ` Cyril Hrubis [this message]
2019-05-20 9:49 ` [LTP] [RFC PATCH 0/1] Fix return value checks for posix apis Cyril Hrubis
2019-05-21 4:41 ` Sandeep Patil
2019-05-21 11:48 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521114629.GC13910@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox