From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 0/1] Fix return value checks for posix apis
Date: Tue, 21 May 2019 13:48:53 +0200 [thread overview]
Message-ID: <20190521114853.GD13910@rei> (raw)
In-Reply-To: <20190521044148.GC7753@google.com>
Hi!
> > > PATCH 1/1 demonstrates the fixes needed for pthread_sigmask/6-1 for
> > > example. This pattern is fairly widespread in open_posix_testsuite.
> > >
> > > After going through the documentation in the project, I wasn't sure if I
> > > tested this correctly. After building, I tried the following
> > >
> > > $ cd testcases/open_posix_testsuite
> > > $ ./bin/run_tesit.sh conformance/interfaces/pthread_sigmask pthread_sigmask_6-1.run-test
> > >
> > > ...and that keeps running into test being skipped due to missing file.
> > > (I do have pthread_sigmask_6-1.run-test in place).
> >
> > Actually I always just run the binary, so in this case doing
> > ./pthread_sigmask_6-1.run-test should suffice.
>
> Ok, I'll try that, but IIRC it did nothing on my laptop. I'll retry.
Looks like the test does not print anything unless there is a failure.
Well the convention in openposix testsuite I started to follow is to
print "Test PASSED" in such case, so this should be fixed (in a
separate patch) as well.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2019-05-21 11:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 4:17 [LTP] [RFC PATCH 0/1] Fix return value checks for posix apis Sandeep Patil
2019-05-20 4:17 ` [LTP] [RFC PATCH 1/1] open_posix_testsuite/pthread_sigmask: fix return value checks Sandeep Patil
2019-05-20 9:53 ` Cyril Hrubis
2019-05-21 4:40 ` Sandeep Patil
2019-05-21 11:46 ` Cyril Hrubis
2019-05-20 9:49 ` [LTP] [RFC PATCH 0/1] Fix return value checks for posix apis Cyril Hrubis
2019-05-21 4:41 ` Sandeep Patil
2019-05-21 11:48 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521114853.GD13910@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox