From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH v2] syscalls/sendmmsg: add new test
Date: Tue, 21 May 2019 16:47:33 +0200 [thread overview]
Message-ID: <20190521144733.GD19326@rei.lan> (raw)
In-Reply-To: <20190419210637.88522-1-smuckle@google.com>
Hi!
> Known issues/questions:
> - This test occasionally gets stuck when the two messages get sent by
> separate sendmmsg calls. The two sendmmsg calls complete successfully
> but recvmmsg blocks indefinitely. I am not yet sure what would cause
> this.
There is a race between the sender and receiver thread, if the sender
thread finishes before the receiver thread binds the socket the packets
are simply dropped since this is SOCK_DGRAM and nobody is listening at
the other side of the socket yet.
You have to synchronize the threads with checkpoints so that the sender
thread does not send anything until the receiver binds the socket.
> - I have not used tst_get_unused_port() because I'm unsure of how that
> function should be made available for both the new and old test API?
> I can just create a duplicate function but is there a cleaner way?
Peter just merged patch that adds this functionality to new library.
You are also missing the SPDX licence identifier and other than this
there are minor coding style violation (hint use checkpatch.pl).
Apart from these the code looks good.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-05-21 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 21:06 [LTP] [RFC PATCH v2] syscalls/sendmmsg: add new test Steve Muckle
2019-04-23 19:50 ` Petr Vorel
2019-05-21 14:47 ` Cyril Hrubis [this message]
2019-07-23 12:31 ` Cyril Hrubis
2019-07-23 16:59 ` Steve Muckle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521144733.GD19326@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox