From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/prctl05.c: New test for prctl() with PR_{SET, GET}_NAME
Date: Thu, 23 May 2019 11:40:03 +0200 [thread overview]
Message-ID: <20190523094003.GC30616@rei.lan> (raw)
In-Reply-To: <1557404414-3797-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>
Hi!
> + TEST(prctl(PR_GET_NAME, &buf));
> + if (TST_RET == -1) {
> + tst_res(TFAIL | TTERRNO, "prctl(PR_GET_NAME) failed");
> + return;
> + }
> +
> + if (!strncmp(thread_name, buf, 15) && strlen(buf) == 15)
^
Here we are calling
strlen() on
potentionally
unterminated buffer
I guess that we should do buf[19] = 0 after the PR_GET_NAME prctl().
> + tst_res(TPASS, "prctl(PR_GET_NAME) succeeded, "
> + "thread name is %s", buf);
> + else
> + tst_res(TFAIL,
> + "prctl(PR_GET_NAME) failed to truncate the name into "
> + "16 byte long");
Can we also check that the /proc/self/task/$tid/comm matches as well?
> +}
> +
> +static struct tst_test test = {
> + .test_all = verify_prctl,
> +};
Other than that it looks good.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-05-23 9:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 12:20 [LTP] [PATCH] syscalls/prctl05.c: New test for prctl() with PR_{SET, GET}_NAME Yang Xu
2019-05-22 10:16 ` xuyang
2019-05-23 9:40 ` Cyril Hrubis [this message]
2019-05-23 11:35 ` [LTP] [PATCH v2] " Yang Xu
2019-05-23 11:51 ` Xiao Yang
2019-05-24 7:36 ` xuyang
2019-05-24 7:50 ` [LTP] [PATCH v3] " Yang Xu
2019-05-24 13:21 ` Cyril Hrubis
2019-05-24 13:45 ` Xiao Yang
2019-05-24 13:48 ` Cyril Hrubis
2019-05-24 13:58 ` Xiao Yang
2019-05-27 8:19 ` [LTP] [PATCH v4] " Yang Xu
2019-05-27 13:41 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523094003.GC30616@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox