From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] insmod01_sh test from commands test suite will make cve-2017-17053 test fail
Date: Fri, 31 May 2019 10:32:03 +0200 [thread overview]
Message-ID: <20190531083203.GA4224@rei.lan> (raw)
In-Reply-To: <CAMy_GT-kRs7_EZvrP-JdFc_wa8OMc3295N6FWUg7AxoY2O66fA@mail.gmail.com>
Hi!
> We found out that when running the LTP test suite directly (which uses
> the "default" file in scenario_groups). The insmod01_sh will insert an
> out-of-tree module and taints the kernel, and the following
> cve-2017-17053 test in the cve test suite will check if the kernel is
> tainted. Thus causing some false-positive in the test result.
>
> Perhaps a workaround is to move the cve test suite to somewhere before
> the commands test suite in the "default" scenario.
>
> BugLink: https://bugs.launchpad.net/bugs/1830011
Looking at the bug the problem is that the module is missing license.
I guess that adding MODULE_LICENSE("GPL"); to the dummy module
testcases/commands/insmod/ltp_insmod01.c should fix it.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-05-31 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 7:41 [LTP] insmod01_sh test from commands test suite will make cve-2017-17053 test fail Po-Hsu Lin
2019-05-31 8:32 ` Cyril Hrubis [this message]
2019-05-31 9:25 ` Cyril Hrubis
2019-05-31 9:43 ` Cyril Hrubis
2019-06-04 11:44 ` Po-Hsu Lin
2019-06-05 7:02 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531083203.GA4224@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox