[LTP] insmod01_sh test from commands test suite will make cve-2017-17053 test fail

Cyril Hrubis
2019-05-31T08:32:03Z

Hi!
> We found out that when running the LTP test suite directly (which uses
> the "default" file in scenario_groups). The insmod01_sh will insert an
> out-of-tree module and taints the kernel, and the following
> cve-2017-17053 test in the cve test suite will check if the kernel is
> tainted. Thus causing some false-positive in the test result.
>
> Perhaps a workaround is to move the cve test suite to somewhere before
> the commands test suite in the "default" scenario.
>
> BugLink: https://bugs.launchpad.net/bugs/1830011

Looking at the bug the problem is that the module is missing license.

I guess that adding MODULE_LICENSE("GPL"); to the dummy module
testcases/commands/insmod/ltp_insmod01.c should fix it.