From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/ioctl_ns0[156]: align stack and wait for child
Date: Wed, 12 Jun 2019 15:59:30 +0200 [thread overview]
Message-ID: <20190612135929.GA3048@rei.lan> (raw)
In-Reply-To: <916c20b9a379badd37a85aa1e1339566c9807d23.1560248542.git.jstancek@redhat.com>
Hi!
> Test crashes (SIGBUS) when using child stack have been observed for
> ioctl_ns01. Align stack to 64 bytes for all testcases using clone,
> which should work for any arch.
Looking at the rest of the test it seems that all of them use malloc()
to allocate the child stack and depends on the libc to align the
buffers, maybe it would be easier to change these tests to use malloc()
as well.
> Add SIGCHLD to clone flags, so that LTP library can reap all children
> and check their return code. Also check ltp_clone() return value.
>
> Suppress warning for unused *arg in child().
The rest is OK.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-06-12 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 10:25 [LTP] [PATCH v2] syscalls/ioctl_ns0[156]: align stack and wait for child Jan Stancek
2019-06-12 1:28 ` Li Wang
2019-06-12 13:59 ` Cyril Hrubis [this message]
2019-06-12 14:25 ` Jan Stancek
2019-06-12 15:21 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612135929.GA3048@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox