From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 3/3] syscalls/bind01: convert to new library.
Date: Thu, 13 Jun 2019 16:55:07 +0200 [thread overview]
Message-ID: <20190613145507.GD29926@rei.lan> (raw)
In-Reply-To: <20190610002610.2187-4-sspatil@android.com>
Hi!
Pushed with minor changes, thanks.
However the test fails with -i 2 after this patch since on second
iteration since the socket is already bind for the possitive test
because we no longer close the socket after each iteration. Looking at
the bind tests we should move this one into a separate testcase and add
a few more positive tests as well we seem to test only AF_INET,
SOCK_STREAM combination which does not even cover ipv4 nor we attemp to
connect to the socket that have been bind.
> +// SPDX-License-Identifier: GPL-2.0
Changed this to GPL-2.0-or-later to match the original license.
And removed the NULL parameter from the TST_GET_UNUSED_PORT(), since
newlib variant does not have the cleanup callback parameter.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-06-13 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 0:26 [LTP] [PATCH v2 0/3] New library conversion for few system call tests Sandeep Patil
2019-06-10 0:26 ` [LTP] [PATCH v2 1/3] syscalls/adjtimex02: Convert to new library Sandeep Patil
2019-07-04 12:51 ` Cyril Hrubis
2019-06-10 0:26 ` [LTP] [PATCH v2 2/3] syscalls/asyncio02: convert " Sandeep Patil
2019-06-13 16:11 ` Cyril Hrubis
2019-06-10 0:26 ` [LTP] [PATCH v2 3/3] syscalls/bind01: " Sandeep Patil
2019-06-13 14:55 ` Cyril Hrubis [this message]
2019-06-13 15:17 ` Cyril Hrubis
2019-06-18 20:25 ` Sandeep Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613145507.GD29926@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox