public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/3] lib: adding .arch field in tst_test structure
Date: Mon, 17 Jun 2019 23:46:19 +0200	[thread overview]
Message-ID: <20190617214619.GB19347@x230> (raw)
In-Reply-To: <20190615042048.29839-1-liwang@redhat.com>

Hi Li,

> Testcases for specified arch should be limited on that only being supported
> platform to run, we now create a function tst_on_arch to achieve this new
> feature in LTP library.  All you need to run a test on the expected arch is
> to set the '.arch' string in the 'struct tst_test' to choose the required
> arch list. e.g. '.arch = "x86_64 i386"'.

> Signed-off-by: Li Wang <liwang@redhat.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>

LGTM. FYI there is also HOST_CPU variable (since 00ff2c348f),
but that does not help your patch.

> ---
>  doc/test-writing-guidelines.txt | 26 ++++++++++
>  include/tst_arch.h              | 16 ++++++
>  include/tst_test.h              |  7 ++-
>  lib/tst_arch.c                  | 92 +++++++++++++++++++++++++++++++++
>  4 files changed, 140 insertions(+), 1 deletion(-)
>  create mode 100644 include/tst_arch.h
>  create mode 100644 lib/tst_arch.c

> diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing-guidelines.txt
> index f1912dc12..b4fba0190 100644
> --- a/doc/test-writing-guidelines.txt
> +++ b/doc/test-writing-guidelines.txt
> @@ -1668,6 +1668,32 @@ sturct tst_test test = {
>  };
>  -------------------------------------------------------------------------------

> +2.2.30 Testing on specified architecture
                     ^ maybe specific?

Kind regards,
Petr

  parent reply	other threads:[~2019-06-17 21:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-15  4:20 [LTP] [PATCH v2 1/3] lib: adding .arch field in tst_test structure Li Wang
2019-06-15  4:20 ` [LTP] [PATCH v2 2/3] testcase: taking use of .arch in tst_test Li Wang
2019-06-17 21:49   ` Petr Vorel
2019-06-15  4:20 ` [LTP] [PATCH v2 3/3] testcase: get rid of compiling errors Li Wang
2019-06-17 21:42   ` Petr Vorel
2019-06-17 21:44   ` Jan Stancek
2019-06-18  4:03     ` Li Wang
2019-06-17 21:46 ` Petr Vorel [this message]
2019-06-18  2:53   ` [LTP] [PATCH v2 1/3] lib: adding .arch field in tst_test structure Li Wang
2019-06-17 21:49 ` Petr Vorel
2019-06-18  3:07   ` Li Wang
2019-06-18  5:51     ` Petr Vorel
2021-11-03 12:00 ` Richard Palethorpe
2021-11-03 14:03   ` Li Wang
2021-11-03 14:10     ` Cyril Hrubis
2021-11-04 10:18       ` Li Wang
2021-11-04 10:26         ` Cyril Hrubis
2021-11-05  9:47           ` Richard Palethorpe
2021-11-05 13:23             ` Li Wang
2021-11-05 13:55               ` Richard Palethorpe
2021-11-05 14:22               ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190617214619.GB19347@x230 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox