From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/3] lib: adding .arch field in tst_test structure
Date: Tue, 18 Jun 2019 07:51:19 +0200 [thread overview]
Message-ID: <20190618055119.GA13571@x230> (raw)
In-Reply-To: <CAEemH2cAFUkmmiokVwvC5YvT1QoXaANxtCjFypnYS309ietX0g@mail.gmail.com>
Hi Li,
> > > Testcases for specified arch should be limited on that only being
> > supported
> > > platform to run, we now create a function tst_on_arch to achieve this new
> > > feature in LTP library. All you need to run a test on the expected arch
> > is
> > > to set the '.arch' string in the 'struct tst_test' to choose the required
> > > arch list. e.g. '.arch = "x86_64 i386"'.
> > Just one note, strings are error prone. I wonder if defining constants and
> > using
> > array would be too complicated for this use case.
> I thought about that array way, but it seems a bit complicted in using.
> Yes, strings are easy to involve typo but we can make a check in library.
OK, agree :).
> Thanks for review.
Kind regards,
Petr
next prev parent reply other threads:[~2019-06-18 5:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-15 4:20 [LTP] [PATCH v2 1/3] lib: adding .arch field in tst_test structure Li Wang
2019-06-15 4:20 ` [LTP] [PATCH v2 2/3] testcase: taking use of .arch in tst_test Li Wang
2019-06-17 21:49 ` Petr Vorel
2019-06-15 4:20 ` [LTP] [PATCH v2 3/3] testcase: get rid of compiling errors Li Wang
2019-06-17 21:42 ` Petr Vorel
2019-06-17 21:44 ` Jan Stancek
2019-06-18 4:03 ` Li Wang
2019-06-17 21:46 ` [LTP] [PATCH v2 1/3] lib: adding .arch field in tst_test structure Petr Vorel
2019-06-18 2:53 ` Li Wang
2019-06-17 21:49 ` Petr Vorel
2019-06-18 3:07 ` Li Wang
2019-06-18 5:51 ` Petr Vorel [this message]
2021-11-03 12:00 ` Richard Palethorpe
2021-11-03 14:03 ` Li Wang
2021-11-03 14:10 ` Cyril Hrubis
2021-11-04 10:18 ` Li Wang
2021-11-04 10:26 ` Cyril Hrubis
2021-11-05 9:47 ` Richard Palethorpe
2021-11-05 13:23 ` Li Wang
2021-11-05 13:55 ` Richard Palethorpe
2021-11-05 14:22 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618055119.GA13571@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox