[LTP] [PATCH v4 2/2] pkey: add test for memory protection keys

Jan Stancek
2019-07-01T07:23:26Z

----- Original Message -----
> On Wed, Jun 26, 2019 at 5:59 PM Jan Stancek <jstancek@redhat.com> wrote:
>
> >
> > ...
> > >
> > > If a system(e.g PowerKVM guest) configured with NO huge page support,
> > then
> > > the file '/proc/sys/vm/nr_hugepages' exist but EOPNOTSUPP to read/write.
> > In
> > > this key01, perhaps I shouldn't use the "/proc/.../nr_hugepages" to
> > detect
> > > that at the beginning.
> > >
> > > Seems the correct way is to use "/sys/kernel/mm/hugepages/" for huge page
> > > detecting and leave the SAFE_FILE_* still in setup(). Because we need to
> > > catch the "/proc/.../nr_hugepages" open/close or read/write issue in
> > > testing.
> >
> > That should work, I see we used that in some tests already.
> >
>
> Thanks, should I format new patch v5? or any more comments?

Yes, please send v5.