From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH RFC] move_pages12: handle errno EBUSY for madvise(..., MADV_SOFT_OFFLINE)
Date: Wed, 3 Jul 2019 15:10:05 +0200 [thread overview]
Message-ID: <20190703131005.GA1712@rei> (raw)
In-Reply-To: <20190607095213.13372-1-liwang@redhat.com>
Hi!
> + if (ret == EINVAL) {
> SAFE_KILL(cpid, SIGKILL);
> SAFE_WAITPID(cpid, &status, 0);
> SAFE_MUNMAP(addr, tcases[n].tpages * hpsz);
> tst_res(TCONF,
> "madvise() didn't support MADV_SOFT_OFFLINE");
> return;
> + } else if (ret == EBUSY) {
> + SAFE_MUNMAP(addr, tcases[n].tpages * hpsz);
> + goto out;
Shouldn't we continue with the test here rather than exit?
I guess that there is no harm in doing a few more iterations if we
manage to hit EBUSY, or is there a good reason to exit the test here?
Otherwise the patch looks good.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-07-03 13:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 9:52 [LTP] [PATCH RFC] move_pages12: handle errno EBUSY for madvise(..., MADV_SOFT_OFFLINE) Li Wang
2019-06-10 3:27 ` Naoya Horiguchi
2019-06-21 5:58 ` Yang Xu
2019-06-24 2:43 ` Li Wang
2019-06-27 2:50 ` Yang Xu
2019-07-04 3:29 ` Li Wang
2019-07-03 13:10 ` Cyril Hrubis [this message]
2019-07-04 5:48 ` Li Wang
2019-07-04 6:23 ` Li Wang
2019-07-10 12:59 ` Cyril Hrubis
2019-07-15 9:33 ` Li Wang
2019-07-24 9:33 ` Li Wang
2019-07-24 10:46 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703131005.GA1712@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox