* [LTP] [PATCH] syscalls/chdir/chdir04.c: fix out-of-bounds write
@ 2019-07-15 12:37 Tobias Jordan
2019-07-15 14:14 ` Cyril Hrubis
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Jordan @ 2019-07-15 12:37 UTC (permalink / raw)
To: ltp
When UCLINUX is defined, line 156 will write to the TC[2].dname:
#ifdef UCLINUX
[...]
TC[2].dname = bad_addr;
#endif
However, TC[2] won't exist as it's only initialized when UCLINUX is
not defined and length of TC is implicit. Remove "#ifndef UCLINUX"
around initializer for TC[2].
Signed-off-by: Tobias Jordan <knilch-ltp@cdqe.de>
---
original posted as github PR:
https://github.com/linux-test-project/ltp/pull/543
testcases/kernel/syscalls/chdir/chdir04.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/testcases/kernel/syscalls/chdir/chdir04.c b/testcases/kernel/syscalls/chdir/chdir04.c
index 9e0a9e9d0..f0420e4c9 100644
--- a/testcases/kernel/syscalls/chdir/chdir04.c
+++ b/testcases/kernel/syscalls/chdir/chdir04.c
@@ -83,14 +83,12 @@ struct test_case_t {
*/
{
noexist_dir, ENOENT},
-#ifndef UCLINUX
/*
* to test whether chdir() is setting EFAULT if the
* directory is an invalid address.
*/
{
(void *)-1, EFAULT}
-#endif
};
int TST_TOTAL = ARRAY_SIZE(TC);
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [LTP] [PATCH] syscalls/chdir/chdir04.c: fix out-of-bounds write
2019-07-15 12:37 [LTP] [PATCH] syscalls/chdir/chdir04.c: fix out-of-bounds write Tobias Jordan
@ 2019-07-15 14:14 ` Cyril Hrubis
0 siblings, 0 replies; 2+ messages in thread
From: Cyril Hrubis @ 2019-07-15 14:14 UTC (permalink / raw)
To: ltp
Hi!
Pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-15 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-15 12:37 [LTP] [PATCH] syscalls/chdir/chdir04.c: fix out-of-bounds write Tobias Jordan
2019-07-15 14:14 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox