public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/acct02.c: Read threshold from /proc/sys/kernel/acct
Date: Mon, 15 Jul 2019 18:00:10 +0200	[thread overview]
Message-ID: <20190715160010.GA30303@rei.lan> (raw)
In-Reply-To: <1563203796-22102-1-git-send-email-ice_yangxiao@163.com>

Hi!
> Don't use hardcoded threshold(default 4%) to check free space
> because it can be changed by writing "/proc/sys/kernel/acct"
> or using sysctl.

Good catch, I missed the sysctl API since I haven't realized that the
proc handlers are all stuffed in a different file in kernel/sysctl.c.

What about we as well temporarily lower the value if needed while the
test is running?

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2019-07-15 16:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 15:16 [LTP] [PATCH] syscalls/acct02.c: Read threshold from /proc/sys/kernel/acct Xiao Yang
2019-07-15 16:00 ` Cyril Hrubis [this message]
2019-07-16 14:04   ` Xiao Yang
2019-07-16 14:17     ` Cyril Hrubis
2019-07-16 15:37       ` Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190715160010.GA30303@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox