From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] syscalls/ustat: Use __kernel_daddr_t instead of daddr_t
Date: Thu, 18 Jul 2019 10:26:55 +0200 [thread overview]
Message-ID: <20190718082655.GA24449@rei.lan> (raw)
In-Reply-To: <20190717173456.GA5272@dell5510>
Hi!
> > This fixes build for musl, which does not have <sys/ustat.h> nor
> > typedef daddr_t. Musl does not define these as ustat is deprecated
> > in favor of statfs() and daddr_t is ancient [1].
>
> > Other libc also does not have <sys/ustat.h> (ustat support was removed
> > from glibc in 2.28), but they have daddr_t.
>
> > This brings <linux/types.h> dependency for ustat testing.
>
> > Typedef is needed as sparc and mips have __kernel_daddr_t long,
> > otherwise it's int.
>
> > [1] https://www.openwall.com/lists/musl/2019/06/10/1
I'm always worried when we use types starting with double underscores
but let's apply this one, we can always revert it in a case that it
breaks build somewhere.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-07-18 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 21:31 [LTP] [PATCH 1/1] syscalls/ustat: Use __kernel_daddr_t instead of daddr_t Petr Vorel
2019-07-17 17:34 ` Petr Vorel
2019-07-18 8:26 ` Cyril Hrubis [this message]
2019-07-29 14:47 ` Petr Vorel
2019-07-18 7:01 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718082655.GA24449@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox