public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] doc: Mention network tests in variables
Date: Thu, 18 Jul 2019 11:29:11 +0200	[thread overview]
Message-ID: <20190718092910.GA25241@rei.lan> (raw)
In-Reply-To: <20190718092037.13594-1-pvorel@suse.cz>

Hi!
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi,
> 
> I'd prefer using hyperlinks in docs (as it's supposed to be viewed
> mainly in a browser) but these are the only variants (which looks too
> ugly to me):
> 
> NOTE: link:../../blob/master/testcases/network/README.md[Network tests] use additional variables
> in 'tst_net.sh'.
> (this one at least keeps links to forks)
> 
> NOTE: https://github.com/linux-test-project/ltp/blob/master/testcases/network/README.md[Network tests] use additional variables
> in 'tst_net.sh'.
> 
> => I'd be for giving up links.

Given that test-writing-guidelines text is also on the LTP wiki the first one would not work anyways...

So yes I do agree that pointing out people to the relative location of
the README.md is probably the best we can do, acked.

> diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing-guidelines.txt
> index 869e6ed35..e59d72065 100644
> --- a/doc/test-writing-guidelines.txt
> +++ b/doc/test-writing-guidelines.txt
> @@ -1883,6 +1883,9 @@ simply by setting right '$TST_NEEDS_FOO'.
>  | 'TST_NEEDS_DRIVERS'| Checks kernel drivers support for the test.
>  |=============================================================================
>  
> +NOTE: Network tests (see testcases/network/README.md) use additional variables
> +in 'tst_net.sh'.
> +
>  Checking for presence of commands
>  +++++++++++++++++++++++++++++++++
>  
> -- 
> 2.22.0
> 

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2019-07-18  9:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18  9:20 [LTP] [PATCH] doc: Mention network tests in variables Petr Vorel
2019-07-18  9:29 ` Cyril Hrubis [this message]
2019-07-18  9:50   ` Petr Vorel
2019-07-22 10:38     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190718092910.GA25241@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox